-
Notifications
You must be signed in to change notification settings - Fork 386
Advertise MAS through the old MSC2965 discovery mechanism #2767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying matrix-website with
|
Latest commit: |
3b99ed6
|
Status: | ✅ Deploy successful! |
Preview URL: | https://9d75bc1b.matrix-website.pages.dev |
Branch Preview URL: | https://quenting-msc2965-old-discove.matrix-website.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 Website & Content WG
Seems sound and matching the spec/MSC2965 and real paths. I'm not enterely clear on: this doesn't appear to be a stable endpoint but only a possible alternative to the MSC proper that was presented as part of the MSC?
I.e. is this for supporting only element specifically? That feels a bit odd. Maybe I missed something skimming the MSC?
That said I would expect a proper review to be done by SRE.
@HarHarLinks this was a previous iteration of the MSC, that some client still use. Ideally, those client would get updated, but a quicker fix is to support this old iteration |
🎩 Website & Content WG @sandhose I see, makes sense. I suppose this is OK as a temporary measure. For context, previous rulings on similar situations were that such things may be OK to do given a clear sunset of the bandaid solution. Aiui there is a policy to not deploy unstable features to m.org where possible to prevent a shadow-spec. I wonder if we should apply the same approach here. |
@HarHarLinks Makes sense. In this case, there are exactly two clients affected: Element Android and Element iOS (legacy), so it will go one of those two ways:
|
After talking to the Website WG, Quentin and SREs, here are the main points considered.
|
Turns out, some clients (like Element iOS and Android legacy) still use the old way of discovering MAS for linking some account management features, and we forgot to update the well-known when we deployed MAS on matrix.org.