Skip to content

Conversation

sandhose
Copy link
Member

Turns out, some clients (like Element iOS and Android legacy) still use the old way of discovering MAS for linking some account management features, and we forgot to update the well-known when we deployed MAS on matrix.org.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 26, 2025

Deploying matrix-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b99ed6
Status: ✅  Deploy successful!
Preview URL: https://9d75bc1b.matrix-website.pages.dev
Branch Preview URL: https://quenting-msc2965-old-discove.matrix-website.pages.dev

View logs

@sandhose sandhose requested a review from thibaultamartin May 26, 2025 10:15
@HarHarLinks HarHarLinks added the homeserver This concerns the Matrix.org homeserver label May 26, 2025
Copy link
Collaborator

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 Website & Content WG

Seems sound and matching the spec/MSC2965 and real paths. I'm not enterely clear on: this doesn't appear to be a stable endpoint but only a possible alternative to the MSC proper that was presented as part of the MSC?
I.e. is this for supporting only element specifically? That feels a bit odd. Maybe I missed something skimming the MSC?

That said I would expect a proper review to be done by SRE.

@sandhose
Copy link
Member Author

@HarHarLinks this was a previous iteration of the MSC, that some client still use. Ideally, those client would get updated, but a quicker fix is to support this old iteration

@HarHarLinks
Copy link
Collaborator

HarHarLinks commented May 26, 2025

🎩 Website & Content WG

@sandhose I see, makes sense. I suppose this is OK as a temporary measure. For context, previous rulings on similar situations were that such things may be OK to do given a clear sunset of the bandaid solution. Aiui there is a policy to not deploy unstable features to m.org where possible to prevent a shadow-spec. I wonder if we should apply the same approach here.

@sandhose sandhose enabled auto-merge May 26, 2025 11:56
@sandhose
Copy link
Member Author

@HarHarLinks Makes sense. In this case, there are exactly two clients affected: Element Android and Element iOS (legacy), so it will go one of those two ways:

  • either those apps get properly sunsetted as EX replaces them
  • or MAS/Synapse get support for the stable MSC2965 endpoints, and those apps adopt the stable endpoints

@thibaultamartin
Copy link
Contributor

After talking to the Website WG, Quentin and SREs, here are the main points considered.

  • The change is not really content but happens to be hosted on the matrix.org repository. As such, the Website WG is not the best placed to approve or deny this request.
  • The change suggested doesn't add any maintenance burden or complexity.
  • It fixes account deactivation issues on versions of Element, dubbed Element Classic, that are still actively distributed in the app stores and used by people.
  • Element Classic does not support the current stable endpoints offered by MAS, and deploying this json file advertises them to Element Classic. This is a vendor-specific solution to help Element during a transition phase, while they either update Element Classic to reach the stable endpoints or sunset Element Classic.
  • Given the impact on users of matrix.org who use Element Classic, the Foundation finds it is in its interest to accommodate Element while it works on getting Element Classic to match the stable version of the spec or sunsets Element Classic.
  • There is a concern that this creates a deviation from the stable specification. The Website WG would like to revisit this change in 6 months.

@sandhose sandhose merged commit b0e39e7 into main May 28, 2025
3 checks passed
@sandhose sandhose deleted the quenting/msc2965-old-discovery branch May 28, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

homeserver This concerns the Matrix.org homeserver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants