-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Add system bus logic and refactor panctl #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VedantSawant616
wants to merge
1
commit into
matrix-org:master
Choose a base branch
from
VedantSawant616:system-bus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # This new file centralizes the logic for D-Bus selection. | ||
|
|
||
| import os | ||
| import dbus | ||
|
|
||
| from dbus.exceptions import DBusException | ||
|
|
||
| def get_bus(bus_choice): | ||
| """ | ||
| Returns a D-Bus connection based on the user's choice. | ||
| Raises RuntimeError if no connection can be made. | ||
| """ | ||
| if bus_choice == "system": | ||
| return dbus.SystemBus() | ||
| elif bus_choice == "session": | ||
| return dbus.SessionBus() | ||
| elif bus_choice == "auto": | ||
| # First, try to connect to the session bus. This is the default | ||
| # behavior for per-user installs. | ||
| try: | ||
| return dbus.SessionBus() | ||
| except DBusException: | ||
| pass # Fallback to system bus if session bus fails | ||
|
|
||
| # If session bus fails, try system bus. | ||
| try: | ||
| return dbus.SystemBus() | ||
| except dbus.DBusException: | ||
| raise RuntimeError("Could not find pantalaimon on session or system bus") | ||
| else: | ||
| raise ValueError(f"Invalid bus choice: {bus_choice}") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,10 @@ | |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
|
|
||
| import argparse | ||
| from pantalaimon.bus_helper import get_bus | ||
|
|
||
| import asyncio | ||
| import json | ||
| import os | ||
|
|
@@ -1394,3 +1398,20 @@ async def shutdown(self, _): | |
| if self.default_session: | ||
| await self.default_session.close() | ||
| self.default_session = None | ||
|
|
||
|
|
||
| def main(): | ||
| parser = argparse.ArgumentParser(description="Pantalaimon Daemon") | ||
| parser.add_argument( | ||
| "--bus", | ||
| choices=["session", "system", "auto"], | ||
| default="auto", | ||
| help="Choose which D-Bus bus to connect to (default: auto)", | ||
| ) | ||
| args = parser.parse_args() | ||
|
|
||
| # Use the helper to get the bus | ||
| bus = get_bus(args.bus) | ||
|
|
||
| # TODO: Place daemon startup logic here | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this PR ready for review? Seems like we've got a significant TODO here. |
||
| print(f"Daemon started with {args.bus} bus: {bus}") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you adjust the README to show these options?