Update synapse pipeline, dropping Python 3.5 builds (#140)

Author: richvdh

synapse/pipeline.yml

@@ -119,14 +119,15 @@ steps:
 
   # -- Special Case: Oldest Python w/ Oldest Deps
 
-  - label: ":python: 3.5 (Old Deps)"
+  - label: ":python: 3.6 (Old Deps)"
     command:
       - ".buildkite/scripts/test_old_deps.sh"
     env:
       TRIAL_FLAGS: "-j 2"
     plugins:
       - docker#v3.7.0:
-          image: "ubuntu:xenial"  # We use xenial to get an old sqlite and python
+          # We use bionic to get an old python (3.6.5) and sqlite (3.22)
+          image: "ubuntu:bionic"
           workdir: "/src"
           mount-buildkite-agent: false
           propagate-environment: true
@@ -154,22 +155,6 @@ steps:
 
   # -- All Supported Python Versions (SQLite)
 
-  - label: ":python: 3.5"
-    command:
-      - *trial_setup
-      - "tox -e py35,combine"
-    env:
-      TRIAL_FLAGS: "-j 2"
-    plugins:
-      - docker#v3.7.0:
-          image: "python:3.5"
-          workdir: "/src"
-          mount-buildkite-agent: false
-          propagate-environment: true
-      - artifacts#v1.3.0:
-          upload: [ "_trial_temp/*/*.log" ]
-    retry: *retry_setup
-
   - label: ":python: 3.6"
     command:
       - *trial_setup
@@ -236,16 +221,16 @@ steps:
 
   #  -- Oldest and Newest Supported Python and Postgres Pairings
 
-  - label: ":python: 3.5 :postgres: 9.5"
+  - label: ":python: 3.6 :postgres: 9.6"
     agents:
       queue: "medium"
     env:
       TRIAL_FLAGS: "-j 8"
-      PYTHON_VERSION: "3.5"
-      POSTGRES_VERSION: "9.5"
+      PYTHON_VERSION: "3.6"
+      POSTGRES_VERSION: "9.6"
     command:
       - *trial_setup
-      - "python -m tox -e py35-postgres,combine"
+      - "python -m tox -e py36-postgres,combine"
     plugins:
       - matrix-org/download#v1.1.0:
           urls:
@@ -322,10 +307,13 @@ steps:
   #
   # We mostly care about testing each topology.
   # To vary the Python and Postgres versions, we use Docker images which are based
-  # on an assortment of Debian releases.
-  #   - "py35" is Debian  9 Stretch (Python 3.5, Postgres 9.6)
-  #   - "py37" is Debian 10 Buster (Python 3.7, Postgres 11)
-  #   - "py38" is Debian 11 Bullseye (Python 3.9, Postgres 13)
+  # on an assortment of Linux distributions.
+  #   - "bionic" (Ubuntu 18.04) has Python 3.6 and Postgres 10
+  #   - "buster" (Debian 10) has Python 3.7 and Postgres 11
+  #   - "bullseye" (Debian 11) (currently) has Python 3.9 and Postgres 13
+  #
+  # TODO: this leaves us without sytests for Postgres 9.6. How much do we care
+  #    about that?
   #
   # Our intent is to test:
   #   - Monolith:
@@ -340,15 +328,15 @@ steps:
   #
   ################################################################################
 
-  - label: "SyTest Monolith :sqlite::debian: 9"
+  - label: "SyTest Monolith :sqlite::ubuntu: 18.04"
     agents:
       queue: "medium"
     command:
       - "bash .buildkite/merge_base_branch.sh"
       - "bash /bootstrap.sh synapse"
     plugins:
       - docker#v3.7.0:
-          image: "matrixdotorg/sytest-synapse:py35"
+          image: "matrixdotorg/sytest-synapse:bionic"
           propagate-environment: true
           always-pull: true
           workdir: "/src"
@@ -364,7 +352,7 @@ steps:
           style: "error"
     retry: *retry_setup
 
-  - label: "SyTest Monolith :postgres::debian: 9"
+  - label: "SyTest Monolith :postgres::ubuntu: 18.04"
     agents:
       queue: "medium"
     env:
@@ -374,7 +362,7 @@ steps:
       - "bash /bootstrap.sh synapse"
     plugins:
       - docker#v3.7.0:
-          image: "matrixdotorg/sytest-synapse:py35"
+          image: "matrixdotorg/sytest-synapse:bionic"
           propagate-environment: true
           always-pull: true
           workdir: "/src"
@@ -400,7 +388,7 @@ steps:
       - "bash /bootstrap.sh synapse"
     plugins:
       - docker#v3.7.0:
-          image: "matrixdotorg/sytest-synapse:py38"
+          image: "matrixdotorg/sytest-synapse:bullseye"
           propagate-environment: true
           always-pull: true
           workdir: "/src"
@@ -416,7 +404,7 @@ steps:
           style: "error"
     retry: *retry_setup
 
-  - label: "SyTest Workers :postgres::debian: 9"
+  - label: "SyTest Workers :postgres::ubuntu: 18.04"
     agents:
       queue: "xlarge"
     env:
@@ -430,7 +418,7 @@ steps:
       - "bash /bootstrap.sh synapse"
     plugins:
       - docker#v3.7.0:
-          image: "matrixdotorg/sytest-synapse:py35"
+          image: "matrixdotorg/sytest-synapse:bionic"
           propagate-environment: true
           always-pull: true
           workdir: "/src"
@@ -460,7 +448,7 @@ steps:
       - "bash /bootstrap.sh synapse"
     plugins:
       - docker#v3.7.0:
-          image: "matrixdotorg/sytest-synapse:py37"
+          image: "matrixdotorg/sytest-synapse:buster"
           propagate-environment: true
           always-pull: true
           workdir: "/src"
@@ -491,7 +479,7 @@ steps:
       - "bash /bootstrap.sh synapse"
     plugins:
       - docker#v3.7.0:
-          image: "matrixdotorg/sytest-synapse:py37"
+          image: "matrixdotorg/sytest-synapse:buster"
           propagate-environment: true
           always-pull: true
           workdir: "/src"
@@ -515,12 +503,12 @@ steps:
   #
   ################################################################################
 
-  - label: "Port DB :python: 3.5 :postgres: 9.5"
+  - label: "Port DB :python: 3.6 :postgres: 9.6"
     agents:
       queue: "medium"
     env:
-      PYTHON_VERSION: "3.5"
-      POSTGRES_VERSION: "9.5"
+      PYTHON_VERSION: "3.6"
+      POSTGRES_VERSION: "9.6"
     command:
       - "bash .buildkite/scripts/test_synapse_port_db.sh"
     plugins: