Open
Conversation
We previously fixed a bug where user ID handling wasn't perfect. This improves it further to also run the validation side of GMSL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously fixed a bug where user ID handling wasn't perfect. This improves it further by checking more of the GMSL code paths, and making the check happen very early in the event check code. This allows filters to drop their custom handling. We also copy the behaviour across the rest of the user ID validation sites for safety.
Fixes #82
We're trying to validate this GMSL path specifically, which swallows errors: https://github.com/matrix-org/gomatrixserverlib/blob/20c9de33969e2df883eaa69c283d6a38efce9284/spec/senderid.go#L72
Tests aren't added for this because we can't mock the data without fighting that very code path.
Pull Request Checklist
mainbranch.