Add support for a JSON configuration file #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path to the configuration file is to be passed through the `-conf` flag. What's more, environment variables will always override settings specified on the JSON file so as to be compatible with existing deployments. Signed-off-by: Pablo Collado Soto <[email protected]>
|
Hi @kegsay! I'm pinging you because the last commit on the repo is yours... Is there any intention of moving froward with this PR? If not I'd be more than happy to close it to try and clean up the clutter... Thanks for your time and sorry for the noise... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strives to add support for specifying the configuration options through a file. This PR is motivated by the discussion on #415.
In order to keep changes as smooth as possible we have chosen to leverage the name of the existing environment variables as the JSON keys. We have also chosen JSON so as to avoid delving into parsing logic; besides, JSON encoding/decoding are part of the standard library.
The path to the configuration file is to be passed through the
-confflag.In order to remain backwards-compatible, environment variables will always override settings specified on the JSON file. The default values for settings will also be honoured.
At any rate, we're more than happy to change anything that might be needed.
Thanks a ton for your time!
Pull Request Checklist