Add code to rewrite Tchap Sygnal URL

[MatMaul]

https://github.com/matrix-org/matrix-dinsic/issues/547

[giomfo]

SGTM

[richvdh]

could this not be done by updating the clients? Hardcoding the change into synapse seems like a poor choice.

[MatMaul]

could this not be done by updating the clients? Hardcoding the change into synapse seems like a poor choice.

So this will also done client side, but we don't control how/if people update their app.
We are also going to rewrite the push URL in existing pushers.

[richvdh]

I'm definitely not enthusiastic about this sort of special-casing, but 🤷‍♂️

[MatMaul]

It's not ideal I agree, but we at least need to keep that for a while. I guess we can reassess that in ~6 months once we will be pretty sure that people have updated their client.

[babolivier]

@MatMaul What's the status on this? Is it still needed? If so I think it should use a configuration setting rather than being hardcoded, that way we can have it in mainline and prevent any divergence. Something like:

rewrite_http_pushers_url:
    - app_id: fr.gouv.btchap
      pusher_url: https://sygnal.preprod.tchap.gouv.fr

[MatMaul]

Good idea 👍 .

Pretty sure it is still needed unfortunately. I'll do that the proper way when this comes around.

[babolivier]

Sounds good, my question was mostly to figure out in which state it was, by the sound of it it sounds like it's on standby from lack of demand but will likely come back on the table in the future.