Remove empty LoggingContext #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the comment on parent repo: matrix-org#56 (comment) Signed-off-by: Adam Hellberg <[email protected]>
reivilibre
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the comments by @richvdh: #56 (comment) and #56 (comment)
I've had this change in my own fork for a long time now and haven't noticed any issue with my Synapse instance, certainly no error logs about the LoggingContext.
This fixes #56 and supersedes #74 (the latter PR changes the
LoggingContextinstead of just removing it).In turn, fixing this
LoggingContextissue makes it start to log what actually happens when this code is hit, the whole "Consumer ask to stop producing". For that issue I'm not sure what the fix would be though. Is this just about the storage provider trying to provide a file to a client that no longer has a connection? That error line happens regularly in my logs.