Remove uploaded file from Synapse's local storage during integration tests#137
Draft
anoadragon453 wants to merge 4 commits intomainfrom
Draft
Remove uploaded file from Synapse's local storage during integration tests#137anoadragon453 wants to merge 4 commits intomainfrom
anoadragon453 wants to merge 4 commits intomainfrom
Conversation
…tests Otherwise the download stage doesn't actually test downloading a file from S3.
anoadragon453
force-pushed
the
anoa/delete_file_during_integration_tests
branch
from
b730e6a to
389e517
Compare
…der into anoa/delete_file_during_integration_tests
Ideally the integration tests fail on this commit.
…der into anoa/delete_file_during_integration_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the download stage doesn't actually test downloading a file from S3.
Spawned from #134 passing tests, yet @erikjohnston found that downloading still failed on his personal homeserver.