Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Downgrade 'Closing scope' error to a warning to prevent hammering sentry #13552

Closed
wants to merge 2 commits into from
Closed

Downgrade 'Closing scope' error to a warning to prevent hammering sentry #13552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ce117
Downgrade 'Closing scope' error to warning; prevent hammering sentry
anoadragon453 Aug 18, 2022
9108872
changelog
anoadragon453 Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/13552.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Downgrade an error that had the capacity to spam Sentry instances to a warning.
2 changes: 1 addition & 1 deletion synapse/logging/scopecontextmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def __str__(self) -> str:
def close(self) -> None:
active_scope = self.manager.active
if active_scope is not self:
logger.error(
logger.warning(
"Closing scope %s which is not the currently-active one %s",
self,
active_scope,
Expand Down