Skip to content

Fix "inbound federation redacts events from erased users" #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix "inbound federation redacts events from erased users" #1205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tests/50federation/32room-getevent.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,22 @@
requires => [
$main::OUTBOUND_CLIENT,
federated_rooms_fixture(),
local_user_fixture(),
],

# On the homeserver under test, have a user `creator` create a public room.
# A second user `remaining_user` on the same HS joins too.
# Sytest acts as a second homeserver and join a user (`user_id`) to that room.
# The `creator` sends a message, then requests deactivation with erasure.
# The homeserver under test should redact that event. Sytest confirms this by
# re-requesting that event. (The `remaining_user` ensures that the homeserver under
# test is still in the room.)

do => sub {
my ( $outbound_client, $creator, $user_id, $room ) = @_;
my ( $outbound_client, $creator, $user_id, $room, $remaining_user ) = @_;
my $first_home_server = $creator->server_name;
my $room_id = $room->room_id;
matrix_join_room($remaining_user, $room_id);

my $message_id;

Expand Down Expand Up @@ -79,7 +89,7 @@
# Check that the content is right
assert_eq( $event->{content}->{body}, "body1" );

# now do the erasure
# The `creator` requests that their account be deactivated.
matrix_deactivate_account( $creator, erase => JSON::true );
})->then( sub {
# re-fetch the event and check that it is redacted.
Expand Down