Skip to content

Fix request body structure for "Should reject keys claiming to belong to a different user" #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

Fix request body structure for "Should reject keys claiming to belong to a different user" #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/41end-to-end-keys/01-upload-key.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@
device_keys => {
user_id => "\@50-e2e-alice:localhost:8480",
device_id => "alices_first_device",
algorithms => ["m.olm.curve25519-aes-sha256", "m.megolm.v1.aes-sha"],
keys => {
"curve25519:".$user->device_id => "curve25519+key",
"ed25519:".$user->device_id => "ed25519+key",
},
signatures => {},
Comment on lines +94 to +99
Copy link
Contributor

@MadLittleMods MadLittleMods Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields make sense in terms of Pydantic model in Synapse (see DeviceKeys)

Feel free to merge if things make sense to you. The fields themselves seem sane.

},
Copy link
Contributor

@MadLittleMods MadLittleMods Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is caused by changes from element-hq/synapse#17097 / element-hq/synapse#19023 ?

I'm a bit confused about how Sytest is passing on Synapse develop if it's from those PRs.

Or since it's optional, why it's failing in (unknown, as described in PR title)?

Copy link
Member Author

@anoadragon453 anoadragon453 Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was passing because it expects a 4xx error:

)->main::expect_http_4xx;

but, as explained in the PR description, we were getting a 400 due to the Pydantic model validation fail. Whereas the test is trying to check that the homeserver will return a 400 when uploading device keys for a user other than yourself.

}
)->main::expect_http_4xx;
Expand Down
Loading