Skip to content

Comments

feat: Only do strict signature verification#299

Open
poljar wants to merge 1 commit intomainfrom
poljar/strict-signatures-by-default
Open

feat: Only do strict signature verification#299
poljar wants to merge 1 commit intomainfrom
poljar/strict-signatures-by-default

Conversation

@poljar
Copy link
Collaborator

@poljar poljar commented Feb 19, 2026

There isn't a particular need to accept keys which are accepted by RFC8032. So let's just always do the strict signature verification.

@poljar poljar requested a review from dkasak as a code owner February 19, 2026 13:27
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2026

Merging this PR will degrade performance by 11.28%

❌ 1 (👁 1) regressed benchmark
✅ 5 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
👁 Decrypting a message 186.2 µs 209.9 µs -11.28%

Comparing poljar/strict-signatures-by-default (722c55f) with main (ee3c987)

Open in CodSpeed

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.35%. Comparing base (ee3c987) to head (722c55f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   91.33%   91.35%   +0.01%     
==========================================
  Files          34       34              
  Lines        4929     4927       -2     
  Branches     4929     4927       -2     
==========================================
- Hits         4502     4501       -1     
+ Misses        273      272       -1     
  Partials      154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants