proxy: distinguish busy CN servers from unavailable CN servers #23606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all CN servers fail due to handshake timeout (typically caused by too many active transactions), return a more specific error message 'all CN servers are busy, possibly due to too many active transactions' instead of the generic 'no available CN server'. This helps users understand that CN servers are actually running but overloaded, rather than being down or unreachable. Changes: - Add timeout flag to connectErr to track timeout failures - Add newTimeoutConnectErr() for creating timeout-specific errors - Add isTimeoutErr() to check if error is timeout-related - Track timeout CN servers separately in BuildConnWithServer() - Return allCNServersBusyErr when all failures are due to timeout - Add test case for timeout error handling
LeftHandCold
requested review from
gouhongshen and
volgariver6
as code owners
matrix-meow
added
size/L
This reverts commit c8c91f5.
matrix-meow
added
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue https://github.com/matrixorigin/matrixflow/issues/8069
What this PR does / why we need it:
When all CN servers fail due to handshake timeout (typically caused by too many active transactions), return a more specific error message 'all CN servers are busy, possibly due to too many active transactions' instead of the generic 'no available CN server'.
This helps users understand that CN servers are actually running but overloaded, rather than being down or unreachable.
Changes: