Skip to content

Fix stderr not printing in TestGoGenerateVendoredPackages #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samherrmann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix stderr not printing in TestGoGenerateVendoredPackages #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions pkg/moq/moq_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,21 +623,24 @@ func TestGoGenerateVendoredPackages(t *testing.T) {
t.Errorf("StdoutPipe: %s", err)
}
defer stdout.Close()
stderr, err := cmd.StderrPipe()
if err != nil {
t.Errorf("StderrPipe: %s", err)
}
defer stderr.Close()
err = cmd.Start()
if err != nil {
t.Errorf("Start: %s", err)
}
buf := bytes.NewBuffer(nil)
io.Copy(buf, stdout)
stdoutBuf := bytes.NewBuffer(nil)
io.Copy(stdoutBuf, stdout)
stderrBuf := bytes.NewBuffer(nil)
io.Copy(stderrBuf, stderr)
err = cmd.Wait()
if err != nil {
if exitErr, ok := err.(*exec.ExitError); ok {
t.Errorf("Wait: %s %s", exitErr, string(exitErr.Stderr))
Copy link
Contributor Author

@samherrmann samherrmann Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in the commit message, because this test does not use cmd.Output(), exitErr.Stderr is always empty.

} else {
t.Errorf("Wait: %s", err)
}
t.Errorf("Wait: %s %s", err, stderrBuf.String())
}
s := buf.String()
s := stdoutBuf.String()
if strings.Contains(s, `vendor/`) {
t.Error("contains vendor directory in import path")
}
Expand Down