Fix GitHub Notifications plugin to support modern PAT tokens#2152
Open
ywzheng1 wants to merge 1 commit intomatryer:mainfrom
Open
Fix GitHub Notifications plugin to support modern PAT tokens#2152ywzheng1 wants to merge 1 commit intomatryer:mainfrom
ywzheng1 wants to merge 1 commit intomatryer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the GitHub Notifications xbar plugin rejecting valid GitHub personal access tokens.
Background
The plugin currently checks for tokens using
len(token) == 40, which worked for classic PATs but no longer works with modern GitHub personal access tokens (e.g.github_pat_...) that are longer and now recommended by GitHub.As a result, valid tokens are silently ignored and the plugin shows only a dot.
Changes
GITHUB_TOKENinstead of assuming a fixed lengthSyntaxWarningsCompatibility
Testing
github_pat_...token