Conversation
paulheinr
commented
Dec 10, 2025
| * @param defaultArgs predefined default arguments that will always be present | ||
| */ | ||
| public static void runWithDefaults(Class<? extends MATSimApplication> clazz, String[] args, String... defaultArgs) { | ||
| public static void startWithDefaults(Class<? extends MATSimApplication> clazz, String[] args, String... defaultArgs) { |
Contributor
Author
There was a problem hiding this comment.
Not sure if this should also be renamed or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #4446 we want to implement a new standard how our scenarios are started with MATSim application. To avoid misunderstandings we renamed
MATSimApplication.run()intoMATSimApplication.start()as this is, what it is doing.runwas missleading, because you could also pass "run" as argument to run the underlying model.FYI @kainagel