fix(config): update relative tolerance handling in GlobalConfigGroup#4695
Open
steffenaxer wants to merge 2 commits intomatsim-org:mainfrom
Open
fix(config): update relative tolerance handling in GlobalConfigGroup#4695steffenaxer wants to merge 2 commits intomatsim-org:mainfrom
steffenaxer wants to merge 2 commits intomatsim-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the handling and validation of the
relativeToleranceForSampleSizeFactorsparameter in theGlobalConfigGroupclass, replacing exceptions with structured warnings and ensuring better configuration consistency. It also adds comprehensive tests to verify correct parameter serialization and default values.Enhancements to configuration validation and error handling:
logScaleFactorWarningmethod inGlobalConfigGroup, which logs structured warnings when scale factors deviate beyond the allowed tolerance. This applies to bothSimWrapperConfigGroupand internalGlobalConfigGroupchecks. [1] [2]relativeToleranceForSampleSizeFactorsparameter, standardizing naming and annotation usage, and fixes the getter to return the actual value (not an offset byDouble.MAX_VALUE).Codebase improvements and test coverage:
logScaleFactorWarninginGlobalConfigGroupto centralize and standardize warning messages for scale factor inconsistencies.GlobalConfigGroupTestto verify correct reading/writing of all parameters (including the new tolerance parameter) and to check default values.Dependency and import updates:
SimWrapperConfigGroupto includeGlobalConfigGroupfor access to the new warning method.Dear @kainagel this a proposal that contains some fixes for your PR. Hope it finds you well 😃