feat(drt): Refactor parallel unplanned request inserter#4713
Open
steffenaxer wants to merge 11 commits intomatsim-org:mainfrom
Open
feat(drt): Refactor parallel unplanned request inserter#4713steffenaxer wants to merge 11 commits intomatsim-org:mainfrom
steffenaxer wants to merge 11 commits intomatsim-org:mainfrom
Conversation
… parallel request insertion
…l time parameters
…in parallel inserter
… improve reporting
…plannedRequestInserter
steffenaxer
changed the title
| * @param d end of ramp-down | ||
| * @return sampled time value | ||
| */ | ||
| private double sampleTrapezoidal(double a, double b, double c, double d) { |
Collaborator
There was a problem hiding this comment.
why trapezoidal and not gaussian/something smoother?
Collaborator
Author
There was a problem hiding this comment.
Will change this in the evening. Good idea. Thanks Mark.
nkuehnel
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new benchmarking framework for DRT (Demand Responsive Transport) scalability experiments in MATSim. It adds three new classes that together enable configuration, execution, and reporting of DRT benchmarks, including both timing and quality metrics. The main changes are grouped below:
Benchmarking Framework Implementation:
BenchmarkResultrecord to encapsulate timing and quality results for a benchmark run, including statistical summaries and extraction of DRT quality metrics from simulation output CSV files. This includes an inner recordDrtQualityStatsfor detailed quality metrics and a staticrunmethod to execute benchmarks. (contribs/drt-extensions/src/main/java/org/matsim/contrib/drt/extension/benchmark/BenchmarkResult.java)DrtBenchmarkRunnerclass to orchestrate multiple benchmark scenarios, handle warmup/measured runs, and generate CSV reports with both performance and quality statistics. It provides a fluent API for adding scenarios and customizing runs. (contribs/drt-extensions/src/main/java/org/matsim/contrib/drt/extension/benchmark/DrtBenchmarkRunner.java)Configuration Enhancements:
DrtBenchmarkConfigGroupclass, a MATSimConfigGroupfor configuring DRT benchmark parameters via XML or code. It supports agent/vehicle counts, partitioner strategies, parallelization settings, output directory, and other benchmark controls, with helper methods for parsing and validation. (contribs/drt-extensions/src/main/java/org/matsim/contrib/drt/extension/benchmark/DrtBenchmarkConfigGroup.java)These additions provide a flexible, extensible foundation for running and analyzing DRT scalability benchmarks within MATSim, with support for both timing and operational quality metrics.