Open
Conversation
…or boolean options. Prevent the annoying prevous behavior when parsing a boolean option followed by variadic arguments parsed the first followed as value for option instead of true and parst the variadic arguments from the second element only. Like `--verbose first second` was parsed where the `verbose` value was `first` instead `true` and the followed array is only `[second]` instead `[first, second]`. In order to achieve this the `shouldTakeNextAsValue` function extracted from `handleConcatenatedOpts` and use it in `handleOptWithoutValue` as well. Resolves mattallty#187
…the inserted one
Owner
|
Thanks for the PR @beci ! Will take a look at it early next week. |
Author
|
Hey @mattallty , it seems github actions misconfigured somehow, as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change: modified boolean option parsing, don't parse the next value for boolean options.
Prevent the annoying prevous behavior when parsing a boolean option followed by variadic arguments parsed the first followed as value for option instead of true and parst the variadic arguments from the second element only. Like
--verbose first secondwas parsed where theverbosevalue wasfirstinsteadtrueand the followed array is only[second]instead[first, second].In order to achieve this the
shouldTakeNextAsValuefunction extracted fromhandleConcatenatedOptsand use it inhandleOptWithoutValueas well. I know this is not the optimal implementation, but I prefered as little modifications as possible. Also, need to change description, because the Option synopsis desciprion is not valid anymore:Also fixed the
rawOptions, where the inverted values was stored for negative flags.