Added avvisi tab for Trentino trasporti routes#7
Open
mattiacoll wants to merge 9 commits intomatteocontrini:mainfrom
Open
Added avvisi tab for Trentino trasporti routes#7mattiacoll wants to merge 9 commits intomatteocontrini:mainfrom
mattiacoll wants to merge 9 commits intomatteocontrini:mainfrom
Conversation
Contributor
Author
|
Upon further investigation on the trains side, there seems to be an alert in the footer of the page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In the past few days there were disruptions to the routes due to either strikes or sporting events in the city, for the website it's not entirely if my route will have any disruption or not.
Proposed solution
The
/routesendpoint exposes anewssection for each route providing additional information regarding any disruption to that route. Therefore i tired adding a section right below the stop to show the news related to the lines for that stop.If there are no news to be shown the button doesn't appear (like now).
I haven't checked in the trains api if there is something similar but i reckon this functionality could also be extended to that part.
Any feedback is more than welcome.
Attached you can see the preview