Fix crashes caused due race condition. #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be the main cause miner dont appear hashing on pool
… loop, same for current
| if (millis() - current_last_hash > 200000) | ||
| if (millis() - current_last_hash > 600000) | ||
| { | ||
| l_error(TAG_CURRENT, "No hash received in the last 3 minutes. Restarting..."); |
Owner
There was a problem hiding this comment.
@KillerInk 10min waiting is not too much?
If fine, worth update the error with the proper amount of time
Contributor
Author
There was a problem hiding this comment.
no its fine. pool.io increase diff to 0.001 and there can be hashtimes longer then 5min where also no new job trigger.
and after 10min then min there should be latest a new job request(new block). if not ,connection realy died.
matteocrippa
approved these changes
Mar 15, 2025
Owner
matteocrippa
left a comment
matteocrippa
left a comment
There was a problem hiding this comment.
Thanks for the contribution @KillerInk
Idrop just a minor comment
Contributor
Author
|
i have to thank you for this piece of code^^ runs faster then the nerdminer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope of the commit
Unit test
Dependencies and Compatibility
AsyncTcp
Documentation
Breaking Changes
miner works without crashing.
optimise send and request with asynctcp
fix timings on job change.
add support for seedstudio xiao s3
Additional Checks
Contributor Guidelines