Skip to content

Update to v0.2.1 of matter-hooks #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LastTalon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update to v0.2.1 of matter-hooks #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/package/matter-hooks/useReducer.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,13 @@ local diffTables = require(Package.diffTables)
end

if increaseCondition then
dispatch("increase")
dispatch({
type = "increase",
})
elseif decreaseCondition then
dispatch("decrease")
dispatch({
type = "decrease",
})
end
```

Expand Down
46 changes: 25 additions & 21 deletions lib/package/matter-hooks/useStream.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,39 +194,43 @@ local function useStream(id: unknown, options: StreamOptions?): () -> (number?,
storage.queue:push(streamInEvent(instance, true))
end),

removingConnection = instance.DescendantRemoving:Connect(function(instance: Instance)
storage.queue:push(streamOutEvent(instance, true))
end),
removingConnection = instance.DescendantRemoving:Connect(
function(instance: Instance)
storage.queue:push(streamOutEvent(instance, true))
end
),
}

for _, descendant in instance:GetDescendants() do
storage.queue:push(streamInEvent(descendant, true))
end
end)

storage.removingConnection = Workspace.DescendantRemoving:Connect(function(instance: Instance)
if instance:GetAttribute(options.attribute) ~= id then
return
end
storage.removingConnection = Workspace.DescendantRemoving:Connect(
function(instance: Instance)
if instance:GetAttribute(options.attribute) ~= id then
return
end

storage.queue:push(streamOutEvent(instance))
storage.queue:push(streamOutEvent(instance))

if not options.descendants then
return
end
if not options.descendants then
return
end

for _, descendant in instance:GetDescendants() do
storage.queue:push(streamOutEvent(descendant, true))
end
for _, descendant in instance:GetDescendants() do
storage.queue:push(streamOutEvent(descendant, true))
end

local connections = storage.trackedInstances[instance]
if not connections then
return
end
local connections = storage.trackedInstances[instance]
if not connections then
return
end

connections.addedConnection:Disconnect()
connections.removingConnection:Disconnect()
end)
connections.addedConnection:Disconnect()
connections.removingConnection:Disconnect()
end
)
end

local index = 0
Expand Down