Skip to content

Conversation

@Apollon77
Copy link
Collaborator

When project-chip/connectedhomeip#42321 lands we need to adjust how we run tests in CI too

The run will fail before the linked PR lands

@Apollon77 Apollon77 requested a review from lauckhart as a code owner December 10, 2025 10:35
Copilot AI review requested due to automatic review settings December 10, 2025 10:35
@Apollon77 Apollon77 marked this pull request as draft December 10, 2025 10:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the CI workflows for upcoming test runner interface changes in the connectedhomeip repository (PR #42321). The changes systematically update all test suite invocations to use a new argument format.

Key Changes:

  • Replaced --chip-tool <path> with --tool-path chip-tool: <path>
  • Replaced specific app arguments (--all-clusters-app, --bridge-app, etc.) with unified --app-path <app-name>: <path> format
  • Applied changes consistently across all test execution workflows

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/official-release.yml Updated test suite arguments for official release chip-tool tests to use new --tool-path and --app-path format
.github/workflows/nightly-dev-release.yml Updated test suite arguments for nightly development release tests to use new parameter format
.github/workflows/chip-tool-tests.yml Updated multiple test job invocations (chip-tests-core, matterjs-tests-core, chip-tests-fast, matterjs-tests-app-fast, chip-tests-simulated, chip-tests-long, matterjs-tests-long) to use new argument format
.github/workflows/chip-matterjs-tests.yml Updated Matter.js controller tests with comprehensive app paths (including lock, lit-icd, microwave-oven, rvc, network-manager, energy-gateway, energy-management) to use new format

@enkiusz
Copy link

enkiusz commented Dec 10, 2025

There should not be a space between the key and path in the --{app,tool}-path arguments, for example --app-path bridge: ../support/chip-testing/dist/esm/BridgeTestApp.js should become --app-path bridge:../support/chip-testing/dist/esm/BridgeTestApp.js

@enkiusz
Copy link

enkiusz commented Jan 14, 2026

The testrunner changes PR has been merged.

@Apollon77
Copy link
Collaborator Author

Very interesting that the old and new approach seems to work in parallel?

@Apollon77 Apollon77 marked this pull request as ready for review January 17, 2026 10:59
@Apollon77 Apollon77 merged commit 9ebbfbc into main Jan 17, 2026
36 checks passed
@Apollon77 Apollon77 deleted the pre-ci-change-runner branch January 17, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants