-
Notifications
You must be signed in to change notification settings - Fork 98
Prepare CI adjustments for upcoming Testrunner changes #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When project-chip/connectedhomeip#42321 lands we need to adjust how we run tests in CI too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR prepares the CI workflows for upcoming test runner interface changes in the connectedhomeip repository (PR #42321). The changes systematically update all test suite invocations to use a new argument format.
Key Changes:
- Replaced
--chip-tool <path>with--tool-path chip-tool: <path> - Replaced specific app arguments (
--all-clusters-app,--bridge-app, etc.) with unified--app-path <app-name>: <path>format - Applied changes consistently across all test execution workflows
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/official-release.yml |
Updated test suite arguments for official release chip-tool tests to use new --tool-path and --app-path format |
.github/workflows/nightly-dev-release.yml |
Updated test suite arguments for nightly development release tests to use new parameter format |
.github/workflows/chip-tool-tests.yml |
Updated multiple test job invocations (chip-tests-core, matterjs-tests-core, chip-tests-fast, matterjs-tests-app-fast, chip-tests-simulated, chip-tests-long, matterjs-tests-long) to use new argument format |
.github/workflows/chip-matterjs-tests.yml |
Updated Matter.js controller tests with comprehensive app paths (including lock, lit-icd, microwave-oven, rvc, network-manager, energy-gateway, energy-management) to use new format |
|
There should not be a space between the key and path in the |
|
The testrunner changes PR has been merged. |
|
Very interesting that the old and new approach seems to work in parallel? |
allow to execute tests against multiple apps
When project-chip/connectedhomeip#42321 lands we need to adjust how we run tests in CI too
The run will fail before the linked PR lands