-
Notifications
You must be signed in to change notification settings - Fork 116
Limit fabric label to 32 characters with truncation and logging #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Apollon77 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: Apollon77 <[email protected]>
@copilot Please check the lint error from CI - see https://github.com/matter-js/python-matter-server/actions/runs/17355814776/job/49268749287?pr=1229#step:5:1 |
- Add missing docstring to __init__ method - Remove unused imports (asyncio, Mock, MagicMock) - Add pylint disable for protected-access in test file - Fix formatting issues (blank lines, newline at end) - Ensure all ruff and pylint checks pass Co-authored-by: Apollon77 <[email protected]>
Fixed the lint errors in commit e14a83e. The issues were in the test file I created: Ruff errors fixed:
Pylint errors fixed:
All lint checks now pass:
The fabric label validation functionality and tests work correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The implementation now includes:
set_default_fabric_label
method to check label length💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.