Reduce Poseidon hash rounds, following 2019/458.#14
Open
alex-ozdemir wants to merge 1 commit intomatter-labs-archive:masterfrom
Open
Reduce Poseidon hash rounds, following 2019/458.#14alex-ozdemir wants to merge 1 commit intomatter-labs-archive:masterfrom
alex-ozdemir wants to merge 1 commit intomatter-labs-archive:masterfrom
Conversation
This commit reduces the number of rounds in the Poseidon hash function
in two ways:
* It correctly interprets the `R_F` parameter as the **total** number
of full rounds.
* The previous implementation incorrectly interpretted the `R_F`
parameter as the number of full rounds **on each side**. That is
actually the `R_f` parameter.
* Relevant citation: 2019/458, page 6, paragraph 3.
* It sets the number of partial rounds to 57, as is reccomended for
x^5-Poseidon
* The previous value, 84, is the reccomended number of partial
rounds for x^3-Poseidon.
* Relevant citation: 2019/458, table 3, row 3.
Note that before this commit, the Poseidon implementation **was not
vulnerable, to the best of our knowledge**. While the implementation
appears to have made two mistakes, it made these mistakes in a way that
improved, not reduced, the security.
Author
|
To be clear: if you guys want to keep the increased number of rounds for security reasons, that is more than reasonable. I'm only submitting the PR because the extra rounds seem to have been implemented by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reduces the number of rounds in the Poseidon hash function
in two ways:
R_Fparameter as the total numberof full rounds.
R_Fparameter as the number of full rounds on each side. That is
actually the
R_fparameter.x^5-Poseidon
rounds for x^3-Poseidon.
Note that before this commit, the Poseidon implementation was not
vulnerable, to the best of our knowledge. While the implementation
appears to have made two mistakes, it made these mistakes in a way that
improved, not reduced, the security.