[CGP] Fix matching of uadd overflow #626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark results: |
vladimirradosavljevic
added a commit
that referenced
this pull request
Jun 18, 2024
This patch fixes the issue where uadd overflow intrinsic is matched for: `Add = add A,(uint64_t)-1; Cmp = icmp ne A, 0` instead of: `Add = add A,-1; Cmp = icmp ne A, 0` where -1 is represented in 256 bits. PR: #626 Signed-off-by: Vladimir Radosavljevic <[email protected]>
vladimirradosavljevic
force-pushed
the
fix_cgp_uadd_overflow_matching
branch
from
6496869 to
c9e4418
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
vladimirradosavljevic
added a commit
that referenced
this pull request
Jun 18, 2024
This patch fixes the issue where uadd overflow intrinsic is matched for: `Add = add A,(uint64_t)-1; Cmp = icmp ne A, 0` instead of: `Add = add A,-1; Cmp = icmp ne A, 0` where -1 is represented in 256 bits. PR: #626 Signed-off-by: Vladimir Radosavljevic <[email protected]>
vladimirradosavljevic
force-pushed
the
fix_cgp_uadd_overflow_matching
branch
from
c9e4418 to
7cfc8ab
Compare
akiramenai
reviewed
Jun 18, 2024
Collaborator
akiramenai
left a comment
akiramenai
left a comment
There was a problem hiding this comment.
It should be upsteamable, shouldn't it? E.g. we don't need i256 target to test this code, a test can be put to generic codegen tests or something.
Add tests where uadd overflow intrinsic is matched for: `Add = add A,(uint64_t)-1; Cmp = icmp ne A, 0` instead of: `Add = add A,-1; Cmp = icmp ne A, 0` where -1 is represented in 256 bits. Signed-off-by: Vladimir Radosavljevic <[email protected]>
This patch fixes the issue where uadd overflow intrinsic is matched for: `Add = add A,(uint64_t)-1; Cmp = icmp ne A, 0` instead of: `Add = add A,-1; Cmp = icmp ne A, 0` where -1 is represented in 256 bits. PR: #626 Signed-off-by: Vladimir Radosavljevic <[email protected]>
vladimirradosavljevic
force-pushed
the
fix_cgp_uadd_overflow_matching
branch
from
7cfc8ab to
098d481
Compare
Contributor
Author
Yes, this can be upstreamed. Unfortunately, there are only few generic CGP tests, others are in |
Contributor
Author
|
Closing in favor of #630. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.