Skip to content

[EVM][ValueTracking] Add support for signextend intrinsic #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[EVM][ValueTracking] Add support for signextend intrinsic #890

wants to merge 6 commits into from

Conversation

@vladimirradosavljevic
Copy link
Contributor

@vladimirradosavljevic vladimirradosavljevic commented Sep 10, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 10, 2025 •
edited
Loading 

Results for: evm ir-llvm EVMInterpreter
╔═╡ Size (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╗
║ Best                                         22.798 ║
║ Worst                                        -4.528 ║
║ Total                                         0.160 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +M3B3 ╞═╣
║ Best                                         33.386 ║
║ Worst                                        -4.088 ║
║ Total                                         0.026 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                          9.070 ║
║ Worst                                        -1.698 ║
║ Total                                         0.026 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                         37.527 ║
║ Worst                                       -10.138 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╗
║ Best                                         20.485 ║
║ Worst                                        -1.389 ║
║ Total                                         0.135 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +MzB3 ╞═╣
║ Best                                         34.148 ║
║ Worst                                        -1.952 ║
║ Total                                         0.031 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                         29.544 ║
║ Worst                                        -0.332 ║
║ Total                                         0.030 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                         38.413 ║
║ Worst                                        -4.622 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╗
║ Best                                         27.737 ║
║ Worst                                        -4.563 ║
║ Total                                         0.211 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                         32.372 ║
║ Worst                                        -2.131 ║
║ Total                                         0.028 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                         13.652 ║
║ Worst                                        -3.123 ║
║ Total                                         0.030 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                         36.798 ║
║ Worst                                        -5.634 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╗
║ Best                                         18.548 ║
║ Worst                                        -4.188 ║
║ Total                                         0.142 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                         32.259 ║
║ Worst                                        -2.131 ║
║ Total                                         0.073 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                         29.206 ║
║ Worst                                        -3.123 ║
║ Total                                         0.064 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                         36.646 ║
║ Worst                                        -5.634 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.146 ║
║ Worst                                         0.000 ║
║ Total                                         0.015 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.046 ║
║ Worst                                         0.000 ║
║ Total                                         0.012 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.146 ║
║ Worst                                         0.000 ║
║ Total                                         0.015 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.046 ║
║ Worst                                         0.000 ║
║ Total                                         0.012 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╗
║ Best                                          1.166 ║
║ Worst                                        -3.676 ║
║ Total                                         0.058 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          1.160 ║
║ Worst                                        -1.171 ║
║ Total                                         0.092 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          0.778 ║
║ Worst                                        -1.533 ║
║ Total                                         0.050 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          1.162 ║
║ Worst                                        -3.725 ║
║ Total                                         0.049 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.451 ║
║ Worst                                         0.000 ║
║ Total                                         0.024 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.302 ║
║ Worst                                         0.000 ║
║ Total                                         0.014 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.461 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.85417% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.10%. Comparing base (e3bf835) to head (5f62683).

Files with missing lines Patch % Lines
llvm/lib/Target/EVM/EVMTargetTransformInfo.cpp 32.75% 27 Missing and 12 partials ⚠️
llvm/lib/Analysis/ValueTracking.cpp 34.54% 28 Missing and 8 partials ⚠️
llvm/lib/Target/EVM/EVMCodegenPrepare.cpp 38.23% 20 Missing and 1 partial ⚠️
...b/Transforms/Scalar/CorrelatedValuePropagation.cpp 28.57% 18 Missing and 2 partials ⚠️
llvm/lib/IR/ConstantRange.cpp 35.29% 8 Missing and 3 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main     #890    +/-   ##
========================================
  Coverage   30.09%   30.10%            
========================================
  Files        2430     2430            
  Lines      806613   806803   +190     
  Branches   176243   176295    +52     
========================================
+ Hits       242781   242868    +87     
- Misses     521685   521782    +97     
- Partials    42147    42153     +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladimirradosavljevic vladimirradosavljevic force-pushed the evm_signextend_valuetracking_support branch from f9bd876 to bcc88e0 Compare September 10, 2025 11:45
@github-actions
Copy link

github-actions bot commented Sep 10, 2025 •
edited
Loading

📊 Excel Report Available

Benchmarks measured for:

  • solx candidate version: solx, LLVM-based Solidity compiler for the EVM v0.1.2, LLVM revision: v1.0.2, LLVM build: 5f62683dcc78373c362b5da0597c57a338040107
  • solx ToT version: solx, LLVM-based Solidity compiler for the EVM v0.1.2, LLVM revision: v1.0.2, LLVM build: e3bf83574a8a276b316c226bac4231e37171c405
  • solx latest release version: solx, LLVM-based Solidity compiler for the EVM v0.1.1, LLVM revision: v1.0.2, LLVM build: b32c5ccab280fd4219e26aceb3f60f425e907498
  • solc version: 0.8.30

➡️ Download Excel Report

@github-actions
Copy link

github-actions bot commented Sep 10, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@vladimirradosavljevic vladimirradosavljevic force-pushed the evm_signextend_valuetracking_support branch from 8ef1203 to 5f62683 Compare September 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vladimirradosavljevic