[mlir][Sol] Revert on failed create/create2 in sol.new lowering#37
Merged
vladimirradosavljevic merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the sol.new lowering to correctly revert when an EVM create/create2 fails (i.e., returns 0), forwarding any revert data produced by the initcode.
Changes:
- Change
sol.newlowering to materializeyul.create/yul.create2as a value instead of directly replacing the op. - Add a
status == 0check aftercreate/create2. - Emit a conditional forwarding revert on failure before replacing the original
sol.newop result.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
vladimirradosavljevic
force-pushed
the
mlir_address_type_builtins
branch
from
7ffc8fe to
d88179f
Compare
Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
vladimirradosavljevic
force-pushed
the
mlir_revert_on_failed_create_create2
branch
from
7708130 to
6425a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solx-solidity PR.