[mlir][Sol] Update checks in ABI decode#41
Merged
vladimirradosavljevic merged 5 commits intomainfrom Mar 18, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Solidity-to-Standard lowering utilities to harden ABI tuple decoding and dynamic memory allocation against malformed offsets/lengths by adding additional bounds checks and a configurable length guard during dynamic allocations.
Changes:
- Extend
genMemAllocForDynArraywith an optionalgenLengthPanicGuardthat panics on lengths exceedingtype(uint64).max. - Add new tuple-bounds helper checks to ABI tuple decoding and apply them to array/string decoding paths.
- Adjust revert reasons and add a trailing-bytes canonicalization store after decoding/copying strings into memory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
mlir/lib/Conversion/SolToStandard/EVMUtil.cpp |
Adds new decoding bounds-check helpers, tightens tuple decoding checks, and introduces an optional length panic guard for dynamic allocations. |
mlir/include/mlir/Conversion/SolToStandard/EVMUtil.h |
Updates the genMemAllocForDynArray API to accept an optional length guard parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
… types This change adds the missing tuple word-range and fixed-array stride bounds checks in MLIR ABI decoding so array/string decode paths correctly revert on out-of-bounds inputs. Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
… decoding Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
vladimirradosavljevic
force-pushed
the
mlir_update_checks_in_abi_decode
branch
from
8d4697f to
94a5ca0
Compare
PavelKopyl
reviewed
Mar 18, 2026
abinavpp
reviewed
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solx-solidity PR.