Skip to content

Conversation

@yoaveshel
Copy link

What ❔

Why ❔

Is this a breaking change?

  • Yes
  • No

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted.

@yoaveshel yoaveshel requested a review from shamatar September 19, 2025 09:24
@yoaveshel
Copy link
Author

@shamatar I fixed the dependency problems, but now the image of zksync_os_verifier is too big to fit in ROM (.text is 2.3MB and ROM is only 2MB). I'm not sure if this is expected or a result of my changes

@yoaveshel
Copy link
Author

CI mostly passes now.

  • full_recursion, oh_bender_incremental_proofs, verification_example and zksync-airbender-test fail becuase of the new ROM boundary
  • ISA tests for simulator and risc_v_tests_delegations fail becuase tests::keccak::test_keccak encounters unreachable code (I think it passes an invalid CSR code, but not sure. @shamatar any idea?)
  • update_verifiers fails curiously, saying it can't load common_constants in the container. Not sure about this one either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants