fix(cudart-sys): strip the "V" from the version string#73
Merged
Conversation
mcarilli
approved these changes
Feb 3, 2025
robik75
force-pushed
the
rr/cuda-version-fix
branch
from
5a7fa75 to
11198ed
Compare
mcarilli
approved these changes
Feb 3, 2025
Artemka374
pushed a commit
that referenced
this pull request
Feb 7, 2025
🤖 I have created a release *beep* *boop* --- ## [0.152.12](v0.152.11...v0.152.12) (2025-02-07) ### Features * Bump crypto versions ([#76](#76)) ([b8cec04](b8cec04)) * **cudart:** refactor allocations and stream ([#75](#75)) ([9c0bedc](9c0bedc)) ### Bug Fixes * **ci:** bump deprecated actions/download-artifact and actions/upload-artifact v3 to v4 ([#74](#74)) ([5727c7c](5727c7c)) * **ci:** Update github-hosted runner label ([#70](#70)) ([822c276](822c276)) * **cudart-sys:** strip the "V" from the version string ([#73](#73)) ([76cfc1c](76cfc1c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
This PR fixes a a bug in the CUDA version detection.
Why ❔
The returned version string fas in the format Vx.y.z instead of x.y.z.