fix(batch_types): explicitly declare required alloy features#1106
Open
LogvinovLeon wants to merge 1 commit intomainfrom
Open
fix(batch_types): explicitly declare required alloy features#1106LogvinovLeon wants to merge 1 commit intomainfrom
LogvinovLeon wants to merge 1 commit intomainfrom
Conversation
batch_types uses alloy::signers and SidecarBuilder but relied on implicit feature unification from l1_sender/operator_signer at the workspace level. This breaks isolated builds (cargo check -p zksync_os_batch_types). Declare the needed features explicitly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test results252 tests 252 ✅ 20m 56s ⏱️ Results for commit 39b2bbc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zksync_os_batch_typesusesalloy::signersandSidecarBuilderbut declaredalloy.workspace = truewith no extra featuresl1_senderandoperator_signercontributedsigner-local/kzgvia Cargo feature unificationcargo check -p zksync_os_batch_types) failed with 4 errors since those features were absentTest plan
cargo check -p zksync_os_batch_typesnow passes in isolationNo tests added — this is a dependency declaration fix with no logic change.
🤖 Generated with Claude Code