chore: add rebuild integration test for unrelated L2 txs#1107
Open
romanbrodetski-ai wants to merge 11 commits intomatter-labs:mainfrom
Open
chore: add rebuild integration test for unrelated L2 txs#1107romanbrodetski-ai wants to merge 11 commits intomatter-labs:mainfrom
romanbrodetski-ai wants to merge 11 commits intomatter-labs:mainfrom
Conversation
This was referenced Mar 27, 2026
RomanBrodetski
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Summary Wait for the previous block to be fully applied before executing the next one, using the startup block boundary as intial value ## Why This removes a race between BlockExecutor and BlockApplier during replay and rebuild. This fix is necessary for #1107 to succeed. ## Validation - the targeted rebuild integration test in #1107 passes with this fix in place Co-authored-by: romanbrodetski-ai <romanbrodetski-ai@users.noreply.github.com>
perekopskiy
reviewed
Mar 30, 2026
RomanBrodetski
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Summary Make invalid-tx handling configurable so rebuild skips invalid transactions without marking the live tx source entry invalid. ## Why This was panicing for Rebuilds - as there is no actual (markable) pool int that case This fix is necessary for #1107 to succeed. ## Validation - the targeted rebuild integration test in #1107 passes with this fix in place --------- Co-authored-by: romanbrodetski-ai <romanbrodetski-ai@users.noreply.github.com>
romanbrodetski-ai
force-pushed
the
upstream-main-pr3-rebuild-integration-test
branch
from
48993a3 to
0bdb89e
Compare
Ensures the rebuild target blocks are above the L1-committed watermark even after the sleep. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…txs" This reverts commit e9756c1.
romanbrodetski-ai
force-pushed
the
upstream-main-pr3-rebuild-integration-test
branch
from
5326be2 to
cbee95f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a rebuild integration test and the small harness hook needed to restart the node with rebuild config overrides.
Why
This captures the regression where rebuilding after emptying a historical block must still preserve unrelated L2 transactions in later blocks.
Validation