[GH-178] Assign moderator to only the user who start the meeting#211
[GH-178] Assign moderator to only the user who start the meeting#211ngoan98tv wants to merge 2 commits intomattermost-community:masterfrom
Conversation
larkox
left a comment
larkox
left a comment
There was a problem hiding this comment.
LGTM. The only question I have is if it is somehow possible to "trick the system" by somehow passing someone else's user id.
larkox
added
2: Dev Review
|
hmm, there is one chance that someone replace I see no way to fake the moderator for now |
ngoan98tv
changed the title
| export class InjectionProvider extends React.Component<any> { | ||
| public render(): JSX.Element { | ||
| const stores = {...this.props}; | ||
| delete stores.children; | ||
| return React.createElement(Provider as any, stores, this.props.children); | ||
| } | ||
| } |
There was a problem hiding this comment.
It fixes this one
There was a problem hiding this comment.
It seems like there should be a cleaner solution for a lint issue like this 🤷 Any thoughts on how this change may introduce a bug? Was this solution sourced from somewhere on the web?
There was a problem hiding this comment.
I get the solution here mobxjs/mobx-react#342 (comment)
There was a problem hiding this comment.
@jespino Curious what you think about this. Probably insignificant
dipak-demansol
requested review from
DHaussermann and
dipak-demansol
and removed request for
dipak-demansol
|
I added the changes in |
hanzei
requested review from
AayushChaudhary0001
and removed request for
DHaussermann
|
Out of curiosity as a present user of this mattermost plugin: Is this change configurable/optional and disabled by default or will this be a breaking change? I'm asking because we actually prefer the current behavior of gaining moderation privileges by using the link in mattermost and then generating a non-privileged link in the meeting to use for external invitations. So this change would break our workflow if not disabled on our instance. |
|
@DaDummy Thanks for commenting here. Sure, I think it makes sense to have this be configurable @ngoan98tv Are you interested in implementing this? Also, would be good to know if you would be open to address any concerns that come up in general with this, as this was submitted quite a while ago. Apologies for the large delay in review here |
hanzei
added
Work In Progress
6 participants
Summary
Adding field
moderatorto JWT claims so it can work withjitsi-token-moderation-pluginto identify moderator.Now, only the user who start the meeting can be moderator
Ticket Link
Fixes #178