ci: add scanner actions and bump all actions#13
Conversation
📝 WalkthroughWalkthroughThese changes update GitHub Actions workflow dependencies and composite actions to use newer versions, and introduce Docker image security scanning into the build process. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/actions/docker-prepare/action.yml (1)
9-9: Buildx engine version is now floating.Line 9 pins the action commit, but without an explicit
with.versionthe Buildx binary uses the latest version available on the GitHub Runner and may change over time. This weakens reproducibility. Consider adding an explicit Buildx version pin and upgrading intentionally.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/actions/docker-prepare/action.yml at line 9, The docker/setup-buildx-action usage currently pins the action commit (uses: docker/setup-buildx-action@4d04d5d...) but omits an explicit Buildx binary version; update the action invocation to include a with.version input to pin the Buildx engine (e.g., with.version: "v0.10.0" or your chosen release) so the buildx binary is reproducible and upgrades are intentional, and document/update the chosen version accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/actions/docker-build/action.yaml:
- Around line 10-17: The Anchore scanner step (anchore/scan-action) is using the
static image name "mattermost/atlantis" instead of the artifact built earlier by
docker/build-push-action; modify the build step (docker/build-push-action) to
include load: true and give the built image a reproducible tag (e.g., set an env
var or output like IMAGE_TAG from the build step), then update the anchore step
to scan that tag (pass the same IMAGE_TAG to the with:image field) so the
scanner analyzes the actual PR-built image instead of the remote latest image.
---
Nitpick comments:
In @.github/actions/docker-prepare/action.yml:
- Line 9: The docker/setup-buildx-action usage currently pins the action commit
(uses: docker/setup-buildx-action@4d04d5d...) but omits an explicit Buildx
binary version; update the action invocation to include a with.version input to
pin the Buildx engine (e.g., with.version: "v0.10.0" or your chosen release) so
the buildx binary is reproducible and upgrades are intentional, and
document/update the chosen version accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4082a4bd-12ce-448a-8f87-7440f7b77566
📒 Files selected for processing (3)
.github/actions/docker-build/action.yaml.github/actions/docker-prepare/action.yml.github/workflows/ci.yml
Summary
Summary by CodeRabbit
Release Notes