Fixed default repo functionality and improve mute user functionality #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbas-dependable-naqvi
requested review from
raghavaggarwal2308 and
wiggin77
abbas-dependable-naqvi
added
2: Dev Review
abbas-dependable-naqvi
changed the title
Contributor
Author
|
@wiggin77 Gentle reminder |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes default repository functionality in the GitHub plugin and improves user muting validation. The changes enhance the repository selector component to properly handle default repositories and fix username validation during the mute user process.
- Fixed default repository selection logic in the GitHub repository selector component
- Enhanced user mute functionality with proper username validation and error handling
- Updated API endpoints to support channel-specific default repository retrieval
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| webapp/src/components/github_repo_selector/index.js | Added currentChannelId to component props for channel-specific operations |
| webapp/src/components/github_repo_selector/github_repo_selector.jsx | Refactored repository selection logic to handle default repositories and improved component state management |
| webapp/src/client/client.ts | Updated API method signature to include channelId parameter for repository queries |
| webapp/src/actions/index.ts | Modified action to pass channelId parameter to repository API calls |
| server/plugin/command.go | Enhanced username validation with proper error handling for GitHub API responses |
| server/plugin/api.go | Extended repository API endpoint to support default repository retrieval and channel-specific queries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@wiggin77 I have replied to the review comments by copilot |
wiggin77
reviewed
Oct 3, 2025
wiggin77
reviewed
Oct 3, 2025
wiggin77
reviewed
Oct 3, 2025
wiggin77
approved these changes
Oct 3, 2025
Contributor
Author
|
@wiggin77 Thanks for helping with the changes |
Contributor
Author
|
@Yash-Chakerverti Please test this PR |
Yash-Chakerverti
approved these changes
Oct 6, 2025
Yash-Chakerverti
left a comment
Yash-Chakerverti
left a comment
There was a problem hiding this comment.
This PR is tested for the following scenarios and working fine:-
- Only the Valid users are being muted
- Only the users present in mute list can be deleted from mute list
- Upon selecting the default repo and running the slash command for creating an issue the repository field is being preselected.
LGTM, Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
Fixes #933