Removing log spam for every user without connected accounts #951
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connected accounts
avasconcelos114
added
2: Dev Review
avasconcelos114
commented
Dec 31, 2025
Comment on lines
611
to
620
| if err != nil && err.ID != apiErrorIDNotConnected { | ||
| c.Log.WithError(err).Errorf("failed to get GitHub user info") | ||
| p.writeAPIError(w, &APIErrorResponse{Message: fmt.Sprintf("failed to get GitHub user info. %s", err.Message), StatusCode: err.StatusCode}) | ||
| return | ||
| } | ||
|
|
||
| if info == nil || info.Token == nil { | ||
| p.writeJSON(w, resp) | ||
| return | ||
| } |
Contributor
Author
There was a problem hiding this comment.
In this case we are letting cases where errors with ID == apiErrorIDNotConnected to be returned (as I think they were intended to) by the check on info == nil
avasconcelos114
changed the title
nevyangelova
approved these changes
Jan 2, 2026
ogi-m
added
Setup Cloud Test Server
|
Test server destroyed |
ogi-m
added
4: Reviews Complete
|
Plugin Spinwick PR #951 🎉 Test server created! Access here: https://github-pr-951-tdhpc.test.mattermost.cloud
The test server was created successfully, but there was an issue installing or enabling the plugin automatically:
You can manually install the plugin:
Future commits will still attempt to automatically update the plugin. Installation ID: Credentials: Posted securely in this Mattermost channel - Look for PR #951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While in other parts of the plugin there is an explicit check on whether the error returned by
getGitHubUserInfois notapiErrorIDNotConnected(because this would mean the account is simply not connected and we should do an early return instead of treating it as a potential bug), these two cases were logging these are errors without evaluating the ID of the errorTicket Link
Fixes https://mattermost.atlassian.net/browse/MM-67031
Fixes #941
QA Steps