Skip to content

Conversation

@avasconcelos114
Copy link
Contributor

Summary

This PR fixes an issue with the configuration state that would cause certain components to run into errors at runtime (due to the default state of configuration being true instead of the actual object that is received by API responses). As well as fixing the main issue with the configuration being overwritten to undefined when the RECEIVED_CONNECTED action is dispatched in various parts of the webapp via the checkAndHandleNotConnected function.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-66428
Fixes #939

QA Steps

  1. Install GitHub plugin on a fresh Mattermost instance
  2. Have a Mattermost user that is a member of at least 2 teams
  3. Click the icon on the sidebar to connect to a GitHub account
  4. Run the /github disconnect command to disconnect accounts
  5. Verify that the icon on the sidebar either disappeared, or remains available to reconnect the account

@avasconcelos114 avasconcelos114 self-assigned this Jan 2, 2026
@avasconcelos114 avasconcelos114 requested a review from a team as a code owner January 2, 2026 19:49
@avasconcelos114 avasconcelos114 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 2, 2026
Copy link

@nevyangelova nevyangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avasconcelos114 avasconcelos114 requested a review from ogi-m January 5, 2026 20:16
@ogi-m ogi-m added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jan 11, 2026
@mm-cloud-bot
Copy link

Test server destroyed

@mm-cloud-bot
Copy link

Plugin Spinwick PR #956 🎉

Test server created!

Access here: https://github-pr-956-jy34u.test.mattermost.cloud

Plugin Version Artifact
github 1052330 Download

⚠️ Plugin Installation Issue

The test server was created successfully, but there was an issue installing or enabling the plugin automatically:

  • Install Error: failed to wait for S3 artifact: timed out waiting for S3 artifact

You can manually install the plugin:

  1. Download the plugin artifact from the link above
  2. Upload it to your test server at yec9eaka7fno5rfqjj5fe5oy8r
  3. Enable it in System Console > Plugins

Future commits will still attempt to automatically update the plugin.

Installation ID: yec9eaka7fno5rfqjj5fe5oy8r
Logs: Click here

Credentials: Posted securely in this Mattermost channel - Look for PR #956

Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogi-m ogi-m added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 12, 2026
@avasconcelos114 avasconcelos114 merged commit 301d040 into master Jan 12, 2026
11 checks passed
@avasconcelos114 avasconcelos114 deleted the MM-66428 branch January 12, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub logo disappears from LHS after disconnecting account

5 participants