Changes from "Created the button and title for landing page"#5
Open
matthew-mcateer wants to merge 2 commits intomainfrom
Open
Changes from "Created the button and title for landing page"#5matthew-mcateer wants to merge 2 commits intomainfrom
matthew-mcateer wants to merge 2 commits intomainfrom
Conversation
Collaborator
|
Hey, @matthew-mcateer. That version of the UI is a bit behind what we currently have, and any further work (from that point on) was done in the nextjs branch. I think I'd initially begun work in the main branch, and only after the initial push did I move to other branches. As such, I think any future changes to the UI shouldn't break anything in main, seeing as they'd now have to go through a PR first. |
|
Kudos, SonarCloud Quality Gate passed!
|
1 similar comment
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @ashenafee I was running into a few issues with the changed to
frontend. It looks good, but I'm going to protect themainbranch so that we don't accidentally breakmain.In the meantime, I reverted the changes in
main, but then I put all those changes back into this branch.