agent(#9): Margin and Padding on base component#11
Draft
matthias-reis wants to merge 4 commits intomainfrom
Draft
agent(#9): Margin and Padding on base component#11matthias-reis wants to merge 4 commits intomainfrom
matthias-reis wants to merge 4 commits intomainfrom
Conversation
Add comprehensive PLAN.md for issue #9 covering margin and padding props on Cask component. Plan includes: - CSS custom properties for 13 spacing scale values - TypeScript types for spacing props (m, ml, mt, mr, mb, mx, my, p, pl, pt, pr, pb, px, py) - Next Yak css mixin integration - Spacing utility functions - Comprehensive test strategy - Risk analysis and rollback strategy Estimated implementation: ~3 hours No new dependencies or architectural changes required.
Implement comprehensive margin and padding props for Cask component using Next Yak CSS mixins and CSS custom properties. **Features:** - 13 spacing scale values (0, 1px, 2px, 4px, 8px, 12px, 16px, 24px, 32px, 48px, 68px, 92px, 122px) - Margin props: m, ml, mr, mt, mb, mx, my - Padding props: p, pl, pr, pt, pb, px, py - Individual props override composite props (cascade order preserved) - Full TypeScript support with type-safe spacing values - Polymorphic compatibility maintained **Implementation:** - CSS custom properties in globals.css - spacing.ts: Type definitions and utility functions - Cask.tsx: Next Yak css mixin integration - 94 passing tests (50 spacing utils + 44 component tests) **Documentation:** - Updated CODEBASE_OVERVIEW.md - Created comprehensive QA checklist **Quality gates:** ✓ All tests pass (pnpm test) ✓ TypeScript compilation succeeds (pnpm typecheck) ✓ Linting passes (biome check) Closes #9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9