WIP: Add a new ResamplerTimer that is attached to the wall clock #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new timer that is attached to the wall clock and can be used to trigger resampling windows. It is a replacement for the channels Timer class that was attached to the monotonic clock. This should fix the issue with the resampling windows being too small when the system clock is not in sync with the wall clock. Signed-off-by: Leandro Lucarella <[email protected]>
|
@llucax what's the status here? |
|
Nothing changed. I need to clean this up, and probably move the wall clock timer to the channels repo. So much to do, so little time... We could close the PR to reduce the noise, as I don't plan to work on it in the short term unless it becomes a thing again, my last understanding was that this almost never happens and that's why the priority was lowered. |
|
I'd keep it open as I fear if we close it now, we will never do it. Let me take the issues back and I'll try to squeeze it in ;). |
|
I will move the discussion to the original PR so it is move visible. |
|
Closing in favor of frequenz-floss#999. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new timer that is attached to the wall clock and can be used to trigger resampling windows. It is a replacement for the channels Timer class that was attached to the monotonic clock.
This should fix the issue with the resampling windows being too small when the system clock is not in sync with the wall clock.