Merge branch 'master' into fix-choicetype-unstringable-value

Author: igneus

features/interactive.feature

@@ -224,6 +224,34 @@ Feature: It is possible to interactively fill in a form from the CLI
         Errors out of the form's scope - do you have validation constraints on properties not used in the form? (Violations on unused fields: data.fieldNotUsedInTheForm)
       """
 
+  Scenario: Checkbox field - answer yes
+    When I run the command "form:coffee" and I provide as input
+    """
+    y[enter]
+    """
+    Then the command has finished successfully
+    And the output should be
+    """
+    Do you want milk in your coffee?: Array
+    (
+        [milk] => 1
+    )
+    """
+
+  Scenario: Checkbox field - answer no
+    When I run the command "form:coffee" and I provide as input
+    """
+    n[enter]
+    """
+    Then the command has finished successfully
+    And the output should be
+    """
+    Do you want milk in your coffee?: Array
+    (
+        [milk] =>
+    )
+    """
+
   Scenario: Choice with options which cannot be converted to string
     When I run the command "form:unstringable_choices" and I provide as input
       """

features/non-interactive.feature

@@ -28,3 +28,16 @@ Feature: It is possible to interactively fill in a form from the CLI
     Options:
      --password
     """
+
+  Scenario: Provide invalid value
+    When I run the command "form:color --color='invalid color'" non-interactively
+    Then the command was not successful
+    And the output should contain
+    """
+    Invalid data provided: color:
+      ERROR: This value is not valid.
+    """
+    And the output should contain
+    """
+    There were form errors.
+    """

src/Bridge/Transformer/CheckboxTransformer.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Matthias\SymfonyConsoleForm\Bridge\Transformer;
+
+use Symfony\Component\Console\Question\ConfirmationQuestion;
+use Symfony\Component\Console\Question\Question;
+use Symfony\Component\Form\FormInterface;
+
+class CheckboxTransformer extends AbstractTransformer
+{
+    /**
+     * @param FormInterface $form
+     *
+     * @return Question
+     */
+    public function transform(FormInterface $form)
+    {
+        return new ConfirmationQuestion($this->questionFrom($form), $this->defaultValueFrom($form));
+    }
+}

src/Bundle/services.yml

@@ -70,6 +70,13 @@ services:
             - { name: form_to_question_transformer, form_type: Symfony\Component\Form\Extension\Core\Type\ChoiceType }
             - { name: form_to_question_transformer, form_type: Symfony\Component\Form\Extension\Core\Type\CountryType }
 
+    matthias_symfony_console_form.checkbox_transformer:
+        class: Matthias\SymfonyConsoleForm\Bridge\Transformer\CheckboxTransformer
+        parent: matthias_symfony_console_form.abstract_transformer
+        public: false
+        tags:
+            - { name: form_to_question_transformer, form_type: Symfony\Component\Form\Extension\Core\Type\CheckboxType }
+
     matthias_symfony_console_form.delegating_interactor:
         class: Matthias\SymfonyConsoleForm\Bridge\Interaction\DelegatingInteractor
         public: false

src/Console/Helper/FormHelper.php

@@ -90,6 +90,10 @@ function (FormInterface $formField) use (&$validFormFields) {
                     },
                     $form->all()
                 );
+
+                if (!$input->isInteractive()) {
+                    throw new \RuntimeException('There were form errors.');
+                }
             }
         } while (!$form->isValid());
 

test/Form/CoffeeMilkType.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Matthias\SymfonyConsoleForm\Tests\Form;
+
+use Symfony\Component\Form\AbstractType;
+use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
+use Symfony\Component\Form\FormBuilderInterface;
+
+/**
+ * Demonstrates use of CheckboxType.
+ */
+class CoffeeMilkType extends AbstractType
+{
+    public function buildForm(FormBuilderInterface $builder, array $options)
+    {
+        $builder
+            ->add('milk', CheckboxType::class, [
+                'label' => 'Do you want milk in your coffee?',
+            ]);
+    }
+}

test/config.yml

@@ -98,6 +98,14 @@ services:
         tags:
             - { name: console.command }
 
+    coffee_command:
+        class: Matthias\SymfonyConsoleForm\Tests\Command\PrintFormDataCommand
+        arguments:
+            - Matthias\SymfonyConsoleForm\Tests\Form\CoffeeMilkType
+            - coffee
+        tags:
+            - { name: console.command }
+
     unstringable_choices_command:
         class: Matthias\SymfonyConsoleForm\Tests\Command\PrintFormDataCommand
         arguments: