Skip to content

Add cross-env#145

Open
wtgtybhertgeghgtwtg wants to merge 6 commits intomattkrick:masterfrom
wtgtybhertgeghgtwtg:master
Open

Add cross-env#145
wtgtybhertgeghgtwtg wants to merge 6 commits intomattkrick:masterfrom
wtgtybhertgeghgtwtg:master

Conversation

@wtgtybhertgeghgtwtg
Copy link
Copy Markdown

This will allow npm scripts to be run on Windows environments.

@mattkrick
Copy link
Copy Markdown
Owner

duplicate of #134
there's another way for windows users to make this work, right?

@wtgtybhertgeghgtwtg
Copy link
Copy Markdown
Author

What I had been doing was changing, for example
"NODE_ENV=development node ./src/server/server.babel.js"
to
"set NODE_ENV=development&& node ./src/server/server.babel.js"
But I don't know if that'd work on other platforms. This seems to be the simplest way.

@mattkrick
Copy link
Copy Markdown
Owner

as an OSX/linux guy i'm biased, but i feel like adding another dependency that is OS-specific is more confusing than just having windows folks prefix their commands with 'set'. I'm not 100% opposed to it, but "set" is shorter & it's expressive, so you know what it does. As a new dev to this repo, I'd probably look up what cross-env does, then realize I don't need it & delete it from all the scripts as well as deps.

@wtgtybhertgeghgtwtg
Copy link
Copy Markdown
Author

The problem with that is that it's not documented. And even if you do document it, Windows users who download the package have to find that document, then alter the package in order to use it.

@mattkrick
Copy link
Copy Markdown
Owner

I'm totally open to documenting it! Currently installing rethinkDB isn't documented for windows. We could add a little something to the readme that says how to install RethinkDB & adjust the scripts. I'm just very hesitant to add in OS-specific stuff, especially when it's an OS that no one will deploy on.

@wtgtybhertgeghgtwtg
Copy link
Copy Markdown
Author

I don't think it's that big of a deal either way. But it is a devDependency for react-look, so wouldn't it be there either way once #141 gets done?

@mattkrick
Copy link
Copy Markdown
Owner

if it's a devDeop, nah. But it's not the size, it's having 1 more thing that meatier is directly responsible for + the mental overhead for a newcomer having to figure out what it is, what it does, and whether they need it or not. If a dependency has sub-dependencies, I don't really care about those because all I'm after is a black box with an API, I don't care how that is achieved. I could see how it'd be beneficial if someone developed on both windows & mac at the same time, and in those scenarios it's just 1 install away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants