-
Notifications
You must be signed in to change notification settings - Fork 44
Implement structured output generation for both LlamaLanguageModel / MLXLanguageModel #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eastriverlee
wants to merge
7
commits into
mattt:main
Choose a base branch
from
eastriverlee:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,789
−149
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
83b8551
Fix SystemLanguageModel to pass schema for structured generation
eastriverlee a6fb713
Implement logit-constrained structured generation for LlamaLanguageModel
eastriverlee 9b1d2db
Implement logit-constrained structured generation for MLXLanguageModel
eastriverlee afcbd9f
Fix duplicate type crash in schema generation
eastriverlee 1d42930
Enforce count + numeric range guides
eastriverlee dc06225
Respect temperature for structured generation
eastriverlee 63bcd14
Refactor Llama and MLX structured generation to shared constrained ge…
eastriverlee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSON character validation excludes backslashes but doesn't handle other control characters that need escaping in JSON (like tabs, newlines, carriage returns when they appear literally in strings). JSON strings must escape control characters (0x00-0x1F) except for the allowed whitespace. Consider either allowing these characters to be properly escaped, or ensuring the validation is consistent with how tokens will actually be used in JSON string generation.