Open
Conversation
Contributor
Author
|
because of pr i made to get the changes to the branch befor it got siconected hopefully now its all as required |
jubnl
requested changes
Apr 7, 2026
Collaborator
There was a problem hiding this comment.
Since you normalize the urls in the DB, could you please add this normalization part when you save the base url ? or just add a warning in the frontend saying something along the line of "Are you sure this normal that this url does not end with /photo"
And in the user settings, please add a bit of documentation regarding sonology (sonology server requirements, so DSM version and so on)
Contributor
Author
|
i normalize url each time iam calling it, i need it to append /photo to old urls in db so dont see necessary to use it when storing new ones sorry i missed the console log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing how synology threats endpoint
Changing auth method in synology from v3 to v6 and adding OTP (MFA) support