Skip to content

Fix #342 polyline disappear when yAxis inverted #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Linho1219 wants to merge 1 commit into from
Closed

Fix #342 polyline disappear when yAxis inverted #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/graph-types/polyline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ export default function polyline(chart: Chart) {
const yRange = chart.meta.yScale.range()
let yMax = yRange[0]
let yMin = yRange[1]

// Fix #342
// When yAxis is reversed, the yRange is inverted, i.e. yMin > yMax
if (yMin > yMax) [yMin, yMax] = [yMax, yMin]

// workaround, clamp assuming that the bounds are finite but huge
const diff = yMax - yMin
yMax += diff * 1e6
Expand Down
Loading