Fix #344 Scatter graph updates #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the graphType to the key to handle graphType updates on the same function.
Owner
mauriciopoppe
left a comment
mauriciopoppe
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left some comments.
| return d.fn || d.r || d.x || d.text | ||
| // Add the graphType to the key to handle graphType updates on the same function (#344) | ||
| return JSON.stringify({ | ||
| function: d.fn || d.r || d.x || d.text, |
Owner
There was a problem hiding this comment.
Now that I think about it, we could plot:
data: [
{fn: 'x'},
{fn: 'x'},
]
In which case the key would be x for both, each one should have a different key instead. I filed another bug to track this #346
Owner
|
Reopen this one as well if you want |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the graphType to the key to handle graphType updates on the same function.
Fixes: #344