Skip to content

feat: refactor to remove zonejs from UserActivityService#693

Merged
mauriciovigolo merged 1 commit intomainfrom
feat/remove-zonejs-dependency
Dec 31, 2025
Merged

feat: refactor to remove zonejs from UserActivityService#693
mauriciovigolo merged 1 commit intomainfrom
feat/remove-zonejs-dependency

Conversation

@mauriciovigolo
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • [] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Removes zone.js and RxJS dependencies from UserActivityService, making the application fully zoneless and better aligned with future Angular versions.

Thanks to @rOBloOm for the suggestion!

Issue Number: #688

What is the new behavior?

Same as the existing functionality.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

--

@mauriciovigolo mauriciovigolo self-assigned this Dec 30, 2025
@mauriciovigolo mauriciovigolo added the enhancement This issue/PR is an enhancement or new feature. label Dec 30, 2025
@mauriciovigolo mauriciovigolo added this to the v21.0.0 milestone Dec 30, 2025
@rOBloOm
Copy link

rOBloOm commented Dec 30, 2025

@mauriciovigolo thank you! looks similar to what i had in mind. just dont forget to remove it from package json. since your still on v20 with this branch all your tests will fail unless you add provideZonelessChangeDetection() with the test modules. not sure if this is necessary with v21.

@badinmichal
Copy link

badinmichal commented Dec 30, 2025

@mauriciovigolo thank you! looks similar to what i had in mind. just dont forget to remove it from package json. since your still on v20 with this branch all your tests will fail unless you add provideZonelessChangeDetection() with the test modules. not sure if this is necessary with v21.

It cannot be removed (rxjs) from package.json because other parts of the code still use it.

@mauriciovigolo
Copy link
Owner Author

@mauriciovigolo thank you! looks similar to what i had in mind. just dont forget to remove it from package json. since your still on v20 with this branch all your tests will fail unless you add provideZonelessChangeDetection() with the test modules. not sure if this is necessary with v21.

The library doesn’t have zone.js as a peer dependency, so I just removed it from the code. This change is also planned for v21.
Thank you for the input and contributions, @rOBloOm!

@mauriciovigolo
Copy link
Owner Author

mauriciovigolo commented Dec 30, 2025

It cannot be removed (rxjs) from package.json because other parts of the code still use it.

I won’t remove rxjs as a peer dependency; I only removed it from that specific code.
Thank you, @badinmichal!

@mauriciovigolo mauriciovigolo force-pushed the feat/remove-zonejs-dependency branch from 81b58ef to 81861bf Compare December 31, 2025 20:43
@mauriciovigolo mauriciovigolo merged commit 05aa6ae into main Dec 31, 2025
7 checks passed
@mauriciovigolo mauriciovigolo deleted the feat/remove-zonejs-dependency branch December 31, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This issue/PR is an enhancement or new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants