feat: refactor to remove zonejs from UserActivityService#693
feat: refactor to remove zonejs from UserActivityService#693mauriciovigolo merged 1 commit intomainfrom
Conversation
|
@mauriciovigolo thank you! looks similar to what i had in mind. just dont forget to remove it from package json. since your still on v20 with this branch all your tests will fail unless you add provideZonelessChangeDetection() with the test modules. not sure if this is necessary with v21. |
It cannot be removed (rxjs) from |
The library doesn’t have |
I won’t remove |
81b58ef to
81861bf
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Removes zone.js and RxJS dependencies from
UserActivityService, making the application fully zoneless and better aligned with future Angular versions.Thanks to @rOBloOm for the suggestion!
Issue Number: #688
What is the new behavior?
Same as the existing functionality.
Does this PR introduce a breaking change?
Other information
--