core: fix MAVLink message sequence #2762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-fix-mavlink-seq
branch
3 times, most recently
from
0d9fa8d to
ac7d6f2
Compare
The MAVLink headers use an inline function to get the mavlink channel, so we end up having separate sequence numbers in different translation units. By defining this function ourselves and linking it later, we make sure to use the same sequence everywhere. This should fix seq numbering that's invalid (per component). We also add a system test to actually test this.
julianoes
force-pushed
the
pr-fix-mavlink-seq
branch
from
ac7d6f2 to
0c09665
Compare
julianoes
force-pushed
the
pr-fix-mavlink-seq
branch
from
0c09665 to
f47718c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MAVLink headers use an inline function to get the mavlink channel, so we end up having separate sequence numbers in different translation units. By defining this function ourselves and linking it later, we make sure to use the same sequence everywhere.
This should fix seq numbering that's invalid (per component).
We also add a system test to actually test this.
Fixes #2759