Fix ReferenceError: closestItem is not defined#1025
Open
C-Ezra-M wants to merge 3 commits intomavoweb:mainfrom
Open
Fix ReferenceError: closestItem is not defined#1025C-Ezra-M wants to merge 3 commits intomavoweb:mainfrom
C-Ezra-M wants to merge 3 commits intomavoweb:mainfrom
Conversation
Occurred to me while trying to use list-separator. This is a temporary solution until this section of code can be properly DRYfied.
✅ Deploy Preview for getmavo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
C-Ezra-M
added a commit
to C-Ezra-M/coben-calc
that referenced
this pull request
Jul 7, 2024
As long as mavoweb/mavo#1025 is active, Netlify will deploy the new codebase as a script that can be included with a <script> tag. I will make it use the upstream version once that PR is merged.
DmitrySharabin
approved these changes
Jul 17, 2024
Member
There was a problem hiding this comment.
Oh, wow. How on earth we didn't notice this earlier? Thank you so much for finding and fixing this.
A bit of context: this code handles the case when one tries to paste multiple items in a list item. I'm not sure how long this feature has been broken. 🤷♂️
Author
|
I believe it's ready to merge. I know there was a force push, but it didn't affect |
Author
|
I'd like to ask if this will ever be merged. It appears that Mavo has not been maintained since 2024. |
Member
|
Hey there, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occurred to me while trying to use list-separator. This is a temporary solution until this section of code can be properly DRYfied.